Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sign-in token api #340

Merged
merged 3 commits into from
Oct 23, 2024
Merged

add sign-in token api #340

merged 3 commits into from
Oct 23, 2024

Conversation

PhilippBuschhaus
Copy link
Contributor

@PhilippBuschhaus PhilippBuschhaus requested a review from a team as a code owner October 22, 2024 19:14
Copy link
Member

@gkats gkats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the contribution @PhilippBuschhaus!

Overall the code looks great. I've left a few comments, could you please take another look and then we can :shipit:.

sign_in_token.go Outdated Show resolved Hide resolved
signintokens/client.go Outdated Show resolved Hide resolved
signintokens/client.go Outdated Show resolved Hide resolved
- rename package
- use pointer for URL as it can be null
- remove references to 'session'
@PhilippBuschhaus
Copy link
Contributor Author

Thank you so much for the contribution @PhilippBuschhaus!

Overall the code looks great. I've left a few comments, could you please take another look and then we can :shipit:.

Thanks for the feedback :). I've addressed the issues but let me know if anything else needs changing.

@gkats gkats merged commit d818ba3 into clerk:v2 Oct 23, 2024
5 checks passed
@MohamedArif20091999
Copy link

@PhilippBuschhaus I could see this code is merged, But With latest "github.com/clerk/clerk-sdk-go/v2" I'm not able to see this module, Is there something I'm missing here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants